Support thumb-mode Armv7-R, Armv7-A and Armv8-R#99
Support thumb-mode Armv7-R, Armv7-A and Armv8-R#99thejpster wants to merge 6 commits intorust-embedded:mainfrom
Conversation
thejpster
force-pushed
the
support-thumb-mode-v7-v8
branch
from
24e6f70 to
96f06f3
Compare
|
In order to be able to test thumb-mode Armv7-R and Armv7-A, we need to be able to mark some functions as being compiled in Thumb mode. However, the armv7a, armv7r and armv8r targets didn't have the thumb-interworking option set. They now do, but only in the latest nightly, not the last stable. I'm wondering in the QEMU tests should always just use nightly and not bother with stable? |
|
Or I guess I could write the function in assembly code... |
thejpster
force-pushed
the
support-thumb-mode-v7-v8
branch
from
96f06f3 to
7ef1f3a
Compare
|
Rebased so it uses #100, and modified to run QEMU tests on nightly (although the libraries themselves are still build on stable and our MSRV). |
|
My justfile changes aren't right - this should fail the build due to missing targets upstream and it does not. |
thejpster
force-pushed
the
support-thumb-mode-v7-v8
branch
from
f02a244 to
7f0a85b
Compare
thejpster
force-pushed
the
support-thumb-mode-v7-v8
branch
2 times, most recently
from
0d4402c to
4dad2b2
Compare
thejpster
changed the title
thejpster
force-pushed
the
support-thumb-mode-v7-v8
branch
from
7013484 to
15d2330
Compare
Now fixed. And that then meant I had to update the outputs. |
Also relies on all the targets having thumb-interworking enabled.
Thanks, macOS :/
You can't depend on the flags because they vary depending on what the machine code does.
They were created before I rebased on main, which had changes to the example programs.
thejpster
force-pushed
the
support-thumb-mode-v7-v8
branch
from
930d07c to
ef61c34
Compare
I went with: * .section * .arm or .thumb * .global * .type * label * code This fixes the smp_test built for thumb mode, which was missing a .arm directive (and the start-up code doesn't work in thumb mode).
thejpster
force-pushed
the
support-thumb-mode-v7-v8
branch
from
ef61c34 to
3a7e27b
Compare
1 participant
Also relies on all the targets having thumb-interworking enabled.
Merge this one before #98